[opencv_core] & [opencv_dart] with android auto ignore unuse abi #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge my code , hurry up pls. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 50 50
Lines 10266 10266
=======================================
Hits 9575 9575
Misses 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
looks fine. will merge it with some minor changes |
|
@einsitang Thanks for your contribution, LGTM now, merged. You can try whether it works for you, if there are any problems, feel free to open new issues or PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build android apk without unuse abi dynamic file
same issue like #211 , oepncv_dart 1.4.1 not support this way , so provide support for this part , and dont use env
OPENCV_DART_ANDROID_ENABLED_ABIanymorecase :
before
after